This repository was archived by the owner on Sep 11, 2025. It is now read-only.
chore: read shared model list from remote #606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjohnsonpint
suggested changes
Nov 22, 2024
Contributor
mattjohnsonpint
left a comment
mattjohnsonpint
left a comment
There was a problem hiding this comment.
Per discussion, the CLI should retrieve the file and keep it locally for the runtime to use. The runtime should also cache it on startup so it's not reading the file with every request.
Contributor
|
Per follow-up discussion, we shouldn't actually need the list at all. We can simply check for a distinct error status such as 404 when the model is invoked, to tell us that the model is not available. |
Contributor
|
Closed in favor of #703 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using a hardcoded list of supported shared models, this reads from a remotely hosted endpoint
Checklist
CHANGELOG.mdfile describing and linking to this PR